aharpervc commented on code in PR #1843:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1843#discussion_r2080184176
##########
tests/sqlparser_common.rs:
##########
@@ -666,6 +666,23 @@ fn parse_select_with_table_alias() {
);
}
+#[test]
+fn parse_consecutive_queries() {
Review Comment:
It turns out doing that seems reasonable and reduces ambiguity. Dialects
that require semicolon delimiters remain unaffected, but dialects where it's
optional would need to quote the keyword as an identifier. That seems
completely reasonable.
##########
tests/sqlparser_common.rs:
##########
@@ -666,6 +666,23 @@ fn parse_select_with_table_alias() {
);
}
+#[test]
+fn parse_consecutive_queries() {
Review Comment:
It turns out doing that seems reasonable and reduces ambiguity. Dialects
that require semicolon delimiters remain unaffected, but dialects where it's
optional would need to quote the keyword as an identifier. That seems
completely reasonable from a parser perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
