2010YOUY01 commented on PR #15256: URL: https://github.com/apache/datafusion/pull/15256#issuecomment-2861663728
> Basically my opinion here is that the few times I tried to review the codecov reports, I found them useless. Maybe it has gotten better since they were originally > > When I tried to look at the report on what lines were/were not covered it the diffs I remember looking at did not make any sense. Also I remember codecov takes a long time and thus was delaying PR CI cycles > > if we are confident that > > 1. This data is actually correct > 2. Reviewers will use the data to improve reviews, > > Then I think it would be a good idea I'm interested to see it when reviewing, but if it slows down CI, we can let it get triggered manually instead of running by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
