andygrove commented on code in PR #1721:
URL: https://github.com/apache/datafusion-comet/pull/1721#discussion_r2078557579
##########
native/core/src/execution/memory_pools/unified_pool.rs:
##########
@@ -76,6 +76,15 @@ impl CometMemoryPool {
}
}
+impl Drop for CometMemoryPool {
+ fn drop(&mut self) {
+ let used = self.used.load(Relaxed);
+ if used != 0 {
+ log::warn!("CometMemoryPool dropped with {} bytes still reserved",
used);
Review Comment:
I don't have any evidence that this condition ever happens, so investing too
much effort here is probably premature. We create `CometMemoryPool` in the
`createPlan` method, so it would be possible to inject the plan ID into the
pool to help with associating the warning with a specific plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
