parthchandra commented on code in PR #1721:
URL: https://github.com/apache/datafusion-comet/pull/1721#discussion_r2078527149
##########
native/core/src/execution/memory_pools/unified_pool.rs:
##########
@@ -76,6 +76,15 @@ impl CometMemoryPool {
}
}
+impl Drop for CometMemoryPool {
+ fn drop(&mut self) {
+ let used = self.used.load(Relaxed);
+ if used != 0 {
+ log::warn!("CometMemoryPool dropped with {} bytes still reserved",
used);
Review Comment:
Would a stacktrace of where this was being dropped be useful?
Though what we really need is this - [arrow-java
HistoricalLog](https://github.com/apache/arrow-java/blob/main/memory/memory-core/src/main/java/org/apache/arrow/memory/util/HistoricalLog.java
). I don't know how to get a combined native+jvm stack trace though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
