andygrove commented on code in PR #1720:
URL: https://github.com/apache/datafusion-comet/pull/1720#discussion_r2078441658
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -96,6 +96,13 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] {
return withInfo(scanExec, fallbackReasons.mkString(", "))
}
+ if (scanImpl == CometConf.SCAN_NATIVE_DATAFUSION &&
scanExec.bucketedScan) {
+ // https://github.com/apache/datafusion-comet/issues/1719
+ fallbackReasons +=
+ "Full native scan disabled because bucketed scan is not supported"
+ return withInfo(scanExec, fallbackReasons.mkString(", "))
Review Comment:
nit: you can call the version that takes a set rather than building a string
here. This will need an import to be added.
```suggestion
return withInfos(scanExec, fallbackReasons.toSet)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
