adriangb opened a new issue, #15952: URL: https://github.com/apache/datafusion/issues/15952
In particular, passing around of `schema` is a bit wonky, see https://github.com/apache/datafusion/pull/15769/files#r2052245527. If we force passing `file_schema` into `ParquetFileSource::new` and such that means as a user you have to pass it into two places. I think the real solution is to have a `FileSourceBuilder` trait that has `build()` method that accepts `file_schema` and produces a `FileScan`. Then `FileScanConfigBuilder` can call that? It might be too much API churn to be worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
