alamb opened a new issue, #15950:
URL: https://github.com/apache/datafusion/issues/15950

   ### Is your feature request related to a problem or challenge?
   
   As explained in the 
[UpgradeGuide](https://datafusion.apache.org/library-user-guide/upgrading.html#parquetexec-avroexec-csvexec-jsonexec-deprecated)
 ParquetExec, AvroExec, CsvExec, JsonExec were deprecated in DataFusion 46
   
   We have just released [DataFusion 
47](https://crates.io/crates/datafusion/47.0.0), so according to the [API 
Deprecation 
Guidelines](https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines),
 we should leave these structures in until at least DataFusion 53. 
   
   However, I strongly suspect that since new code / tests are using the 
`DataSourceExec` the older structures are likely to start ["bit 
rotting"](https://en.wikipedia.org/wiki/Software_rot) (aka not working but we 
won't be able to tell because all tests are using the new structures). Here is 
an example:
   - https://github.com/apache/datafusion/pull/15769/files#r2051611909
   
   This I think a better user experience will be to force users to upgrade by 
removing the old untested versions now 
   
   That would be:
   * `ParquetExec`: 
https://github.com/apache/datafusion/blob/555fc2e24dd669e44ac23a9a1d8406f4ac58a9ed/datafusion/datasource-parquet/src/mod.rs#L73
   * `AvroExec`: 
https://github.com/apache/datafusion/blob/555fc2e24dd669e44ac23a9a1d8406f4ac58a9ed/datafusion/datasource-avro/src/source.rs#L48
   * `CsvExec`: 
https://github.com/apache/datafusion/blob/555fc2e24dd669e44ac23a9a1d8406f4ac58a9ed/datafusion/datasource-csv/src/source.rs#L220
   * `NDJsonExec`: 
https://github.com/apache/datafusion/blob/555fc2e24dd669e44ac23a9a1d8406f4ac58a9ed/datafusion/datasource-json/src/source.rs#L58
   
   ### Describe the solution you'd like
   
   I propose removing the old deprecated code early
   
   ### Describe alternatives you've considered
   
   I recommend an individual PR to remove each structure in turn
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to