alamb commented on code in PR #15841:
URL: https://github.com/apache/datafusion/pull/15841#discussion_r2074030018
##########
datafusion/physical-optimizer/src/enforce_distribution.rs:
##########
@@ -950,11 +949,7 @@ fn add_spm_on_top(input: DistributionContext) ->
DistributionContext {
let new_plan = if should_preserve_ordering {
Arc::new(SortPreservingMergeExec::new(
- input
- .plan
- .output_ordering()
- .unwrap_or(&LexOrdering::default())
- .clone(),
+ input.plan.output_ordering().cloned().unwrap_or_default(),
Review Comment:
the original code clones the output ordering too so this looks equivalent to
me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
