aharpervc commented on code in PR #1836:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1836#discussion_r2073809648
##########
src/parser/mod.rs:
##########
@@ -12987,23 +12991,34 @@ impl<'a> Parser<'a> {
/// Parse a GRANT statement.
pub fn parse_grant(&mut self) -> Result<Statement, ParserError> {
- let (privileges, objects) =
self.parse_grant_revoke_privileges_objects()?;
+ let (privileges, objects) =
self.parse_grant_deny_revoke_privileges_objects()?;
self.expect_keyword_is(Keyword::TO)?;
let grantees = self.parse_grantees()?;
let with_grant_option =
self.parse_keywords(&[Keyword::WITH, Keyword::GRANT,
Keyword::OPTION]);
- let granted_by = self
- .parse_keywords(&[Keyword::GRANTED, Keyword::BY])
- .then(|| self.parse_identifier().unwrap());
+ let as_grantor = if self.peek_keyword(Keyword::AS) {
+ self.parse_keywords(&[Keyword::AS])
+ .then(|| self.parse_identifier().unwrap())
Review Comment:
I've refactored these three related methods to avoid unwrap 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
