adriangb commented on code in PR #15801:
URL: https://github.com/apache/datafusion/pull/15801#discussion_r2073150977
##########
datafusion/physical-plan/src/filter_pushdown.rs:
##########
@@ -191,6 +191,7 @@ impl<T> FilterPushdownPropagation<T> {
#[derive(Debug, Clone)]
pub struct FilterDescription {
+ num_children: usize,
Review Comment:
Yes sorry forgot to implement it but my thought was that you pass in the
size to `new()` and then if you add filters you're forced to either add the
right number (one per child) or use the broadcast helper functions. I want to
make it error if you do e.g.
`FilterDescription::new(1).with_parent_filters(vec![vec![predicate],
vec![predicate]])`. I've implemented an internal refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
