andygrove commented on code in PR #1667:
URL: https://github.com/apache/datafusion-comet/pull/1667#discussion_r2066356877
##########
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##########
@@ -56,23 +65,46 @@ trait DataTypeSupport {
* @return
* true if all fields in the struct are supported
*/
- def isSchemaSupported(struct: StructType): Boolean = {
- struct.fields.map(_.dataType).forall(isTypeSupported)
+ def isSchemaSupported(struct: StructType, fallbackReasons:
ListBuffer[String]): Boolean = {
+ struct.fields.forall(f => validateTypeSupported(f.dataType, f.name,
fallbackReasons))
}
- def isTypeSupported(dt: DataType): Boolean = {
- if (isGloballySupported(dt) || isAdditionallySupported(dt)) {
+ def validateTypeSupported(
Review Comment:
Because this method still returns a boolean, I think that the name should
still be `isTypeSupported`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
