berkaysynnada commented on code in PR #15793:
URL: https://github.com/apache/datafusion/pull/15793#discussion_r2062667570
##########
datafusion/common/src/config.rs:
##########
@@ -1995,11 +2052,11 @@ config_namespace! {
}
}
-pub trait FormatOptionsExt: Display {}
+pub trait OutputFormatExt: Display {}
#[derive(Debug, Clone, PartialEq)]
#[allow(clippy::large_enum_variant)]
-pub enum FormatOptions {
+pub enum OutputFormat {
Review Comment:
Thank you @blaginin, this PR is really nice. I've made a quick look, and
think that perhaps we should rename this config in even all places as "output
format" ? Directly saying "datafusion.format" etc. could make people think
something related with objects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
