andygrove commented on code in PR #1643:
URL: https://github.com/apache/datafusion-comet/pull/1643#discussion_r2042233446
##########
native/core/src/execution/shuffle/row.rs:
##########
@@ -1876,937 +1878,834 @@ fn make_builders(
(DataType::Boolean, DataType::Boolean) => {
let key_builder = downcast_builder!(BooleanBuilder,
key_builder);
let value_builder = downcast_builder!(BooleanBuilder,
value_builder);
- Box::new(MapBuilder::new(
- Some(map_fieldnames),
- *key_builder,
- *value_builder,
- ))
+ Box::new(
+ MapBuilder::new(Some(map_field_names), *key_builder,
*value_builder)
+ .with_values_field(Arc::clone(value_field)),
Review Comment:
note for other reviewers: this seems to be the main change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
