comphead commented on code in PR #1643:
URL: https://github.com/apache/datafusion-comet/pull/1643#discussion_r2041175431


##########
native/core/src/execution/shuffle/row.rs:
##########
@@ -904,7 +904,7 @@ pub(crate) fn append_field(
                     append_map_element!(StringBuilder, Decimal128Builder, 
field);
                 }
                 (DataType::Utf8, DataType::Struct(_)) => {
-                    append_map_element!(StringBuilder, StructBuilder, field);
+                    //append_map_element!(StringBuilder, StructBuilder, field);

Review Comment:
   Map arm branches takes too much of space in this file, proposing to move Map 
arm branches into a separate file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to