2010YOUY01 commented on code in PR #15594:
URL: https://github.com/apache/datafusion/pull/15594#discussion_r2041433804
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1036,13 +1040,73 @@ impl SessionContext {
variable, value, ..
} = stmt;
- let mut state = self.state.write();
- state.config_mut().options_mut().set(&variable, &value)?;
- drop(state);
+ // Check if this is a runtime configuration
+ if variable.starts_with("datafusion.runtime.") {
+ self.set_runtime_variable(&variable, &value)?;
+ } else {
+ let mut state = self.state.write();
+ state.config_mut().options_mut().set(&variable, &value)?;
+ drop(state);
+ }
self.return_empty_dataframe()
}
+ fn set_runtime_variable(&self, variable: &str, value: &str) -> Result<()> {
+ let key = variable.strip_prefix("datafusion.runtime.").unwrap();
+
+ match key {
+ "memory_limit" => {
+ let memory_limit = Self::parse_memory_limit(value)?;
+
+ let mut state = self.state.write();
+ let mut builder =
+ RuntimeEnvBuilder::from_runtime_env(state.runtime_env());
Review Comment:
This implementation is all cloning `Arc`s inside `RuntimeEnv`, I think it
shouldn't have any issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
