LiaCastaneda commented on PR #15580: URL: https://github.com/apache/datafusion/pull/15580#issuecomment-2783707103
> Thank you @LiaCastaneda for the quick response. This is LGTM now. Can you just add an .slt test with a column including a name with ":", and projected across the plan, so this will not be broken in the future. I couldn't manage to find a reproducer with a column with the original name containing ":" on the top level projection that at the same time suffixed the column name with ":" because of name conflicts. I tried also with substrait, but in my substrait reproducer the ":" is added on the aggregate of the top level projection so its a bit complicated to modify the name. I added a unit test for this function though :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
