andygrove opened a new issue, #1630:
URL: https://github.com/apache/datafusion-comet/issues/1630
### Describe the bug
When creating the native plan for `first_value` / `last_value` aggregates,
we currently hard-code `ignoreNulls` instead of using the value from the
protobuf encoding:
```rust
AggregateExprBuilder::new(Arc::new(func), vec![child])
.schema(schema)
.alias("first")
.with_ignore_nulls(false) <-- this should not be
hard-coded!
```
### Steps to reproduce
_No response_
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
