acking-you commented on issue #15636: URL: https://github.com/apache/datafusion/issues/15636#issuecomment-2789008443
@kosiew Thank you very much for your hard work and contribution. However, there might still be a point regarding a short-circuit optimization worth discussing: https://github.com/apache/datafusion/issues/15631#issuecomment-2788923437 If this optimization is confirmed, I think it could be achieved by returning an `enum` structure similar to the one below: ```rust enum ShortCircuitStrategy<'a> { None, ReturnLeft, ReturnRight, PreSelection(&'a BooleanArray), } match check_short_circuit(&lhs, &self.op) { ShortCircuitStrategy::None => (), ShortCircuitStrategy::ReturnLeft => return Ok(lhs), ShortCircuitStrategy::ReturnRight => return self.right.evaluate(batch), ShortCircuitStrategy::PreSelection(boolean_array) => { return self.right.evaluate_selection(batch, boolean_array); } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
