iffyio commented on code in PR #1799:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1799#discussion_r2035155339


##########
tests/sqlparser_snowflake.rs:
##########
@@ -3516,3 +3516,87 @@ fn test_alter_session_followed_by_statement() {
         _ => panic!("Unexpected statements: {:?}", stmts),
     }
 }
+
+#[test]
+fn test_nested_join_without_parentheses() {
+    let query = "SELECT DISTINCT p.product_id FROM orders AS o INNER JOIN 
customers AS c INNER JOIN products AS p ON p.customer_id = c.customer_id ON 
c.order_id = o.order_id";
+    assert_eq!(
+        only(
+            snowflake()
+                .verified_only_select_with_canonical(query, "")

Review Comment:
   ah I see, yeah in that case I think we can include the canonical 
representation to assert on in place of the empty string. [Here for 
example](https://github.com/apache/datafusion-sqlparser-rs/blob/c788526151d958a60896fcef156306af8ba99ea5/tests/sqlparser_snowflake.rs#L2717)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to