alamb commented on code in PR #15466:
URL: https://github.com/apache/datafusion/pull/15466#discussion_r2033373202
##########
datafusion/functions-aggregate/benches/array_agg.rs:
##########
@@ -19,17 +19,23 @@ use std::sync::Arc;
use arrow::array::{
Array, ArrayRef, ArrowPrimitiveType, AsArray, ListArray, NullBufferBuilder,
+ PrimitiveArray,
};
use arrow::datatypes::{Field, Int64Type};
-use arrow::util::bench_util::create_primitive_array;
use criterion::{black_box, criterion_group, criterion_main, Criterion};
use datafusion_expr::Accumulator;
use datafusion_functions_aggregate::array_agg::ArrayAggAccumulator;
use arrow::buffer::OffsetBuffer;
-use arrow::util::test_util::seedable_rng;
use rand::distributions::{Distribution, Standard};
+use rand::prelude::StdRng;
use rand::Rng;
+use rand::SeedableRng;
+
Review Comment:
I inlined the small amount of code from bench_util so this benchmark is
standalone and easier to understand what is tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
