jayzhan211 commented on PR #15600: URL: https://github.com/apache/datafusion/pull/15600#issuecomment-2786456085
> > > > @chenkovsky do you have any idea about the root cause of the problem? I think this PR shouldn't close the issue until fixing/understanding the underlying problem > > > > > > > > > @berkaysynnada I think for rust, it's very easy to stackoverflow. because rust will put many things on stack. you can see, recursive_protection is already used for many recursive functions in datafusion. > > > > > > It depends, #15588 I encounter stack overflow in this issue, after I move out the function and reduce the "stack size" the stack overflow is gone. `sql_array_literal` is another one example too. `try_from_physical_plan` has the large function body, so maybe you can try to move the recursive-heady code out as a function to reduce the stack size. > > @jayzhan211 i pushed a commit, is it what you mean? I tested it, it works, no stackoverflow anymore. but the diff is much larger. Great that it works, that is exactly what I mean. > the diff is much larger. That is totally fine if this fixes the stack overflow issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
