berkaysynnada commented on PR #15479: URL: https://github.com/apache/datafusion/pull/15479#issuecomment-2786362233
> @berkaysynnada I had a look at `ExecutionPlanProperties::pipeline_behavior()`. I think it is not _quite_ what I want here: For the HashJoin, I want to remove the coalesce on the build side, but keep it on the probe side. The pipeline behaviour doesn't tell me which child is processed batch-wise, and which child is processed incrementally. I understand why it doesn't fit in this use case. Maybe we should have another API for operators like pipeline_behavior: `accumulate_input_batches(&self) -> Vec<bool>`? HashJoin implements as vec![true,false], SortExec implements [true], AggregateExec [true] if it has not an ordered input on gb keys, FilterExec has [false] etc. WDYT? That would be an over-engineering or reflects the behaviors better? Maybe we can utilize that in other places as well where we downcast operators and check the type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
