joaoferrao commented on code in PR #1230:
URL:
https://github.com/apache/datafusion-ballista/pull/1230#discussion_r2033050934
##########
ballista/core/src/object_store.rs:
##########
@@ -86,10 +86,10 @@ pub fn custom_runtime_env_with_s3_support(
///
/// It will configure [SessionState] with provided [SessionConfig],
/// and [RuntimeEnv].
-pub fn custom_session_state_with_s3_support(
+pub fn session_state_with_s3_support(
session_config: SessionConfig,
) -> datafusion::common::Result<SessionState> {
- let runtime_env = custom_runtime_env_with_s3_support(&session_config)?;
+ let runtime_env = runtime_env_with_s3_support(&session_config)?;
Review Comment:
Isn't it the case that if you leave out `.with_default_features()`, Ballista
won't have even default UDAFs such as `count`, `avg`, etc.?
I have just started to learn how how DataFusion and Ballista work, sorry in
case this doesn't make sense as I'm still a bit confused on the topics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
