alamb opened a new pull request, #15632:
URL: https://github.com/apache/datafusion/pull/15632

   ## Which issue does this PR close?
   
   
   - part of https://github.com/apache/datafusion/issues/15631
   - follow up to https://github.com/apache/datafusion/pull/15462
   
   ## Rationale for this change
   
   Some of these benchmarks were written for the wonderful analysis by 
@acking-you  in https://github.com/apache/datafusion/pull/15462 of bool_or vs 
count_ones. While they were helpful for that  analysis, they really are micro 
benchmarks for arrow kernels, not DataFusion so I think they don't belong in 
this repo.
   
   Since most of the binary.rs operations call into arrow kernels, I didn't 
think adding more was useful at this time.
   
   
   ## What changes are included in this PR?
   
   1. Remove arrow kernel benchmarks
   2. rename the short circuit benchmarks
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to