adriangb commented on code in PR #15566: URL: https://github.com/apache/datafusion/pull/15566#discussion_r2032103422
########## datafusion/physical-plan/src/filter_pushdown.rs: ########## @@ -0,0 +1,63 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +/// Result of trying to push down fitlers to a child plan. +/// This is used by [`FilterPushdownResult`] to indicate whether the filter was +/// "absorbed" by the child ([`FilterPushdownSupport::Exact`]) or not +/// ([`FilterPushdownSupport::Unsupported`]). +/// If the filter was not absorbed, the parent plan must apply the filter +/// itself, or return to the caller that it was not pushed down. +/// If the filter was absorbed, the parent plan can drop the filter or +/// tell the caller that it was pushed down by forwarding on the [`FilterPushdownSupport::Exact`] +/// information. +#[derive(Debug, Clone, Copy)] +pub enum FilterPushdownSupport { + /// Filter may not have been pushed down to the child plan, or the child plan + /// can only partially apply the filter but may have false positives (but not false negatives). + /// In this case the parent **must** behave as if the filter was not pushed down + /// and must apply the filter itself. + Unsupported, Review Comment: Done: e3c7343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
