alamb commented on code in PR #15613:
URL: https://github.com/apache/datafusion/pull/15613#discussion_r2031216678
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -149,21 +149,48 @@ pub trait MemoryPool: Send + Sync + std::fmt::Debug {
/// For help with allocation accounting, see the [`proxy`] module.
///
/// [proxy]: datafusion_common::utils::proxy
-#[derive(Debug, PartialEq, Eq, Hash, Clone)]
+#[derive(Debug)]
Review Comment:
It is still ok for this struct to derive Hash, right?
In terms of clone, perhaps we can add a method like `pub fn
clone_with_new_id(&self)` that can be explicitly called to clone the memory
consumer while providing a new id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
