alamb commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2783269895
> I've added commits to address the CI failures. > > Of course you're welcome to add some tests to not break these features in the future :-) As documented in the contribution guidelines https://datafusion.apache.org/contributor-guide/testing.html#testing > All new features should have test coverage Thus I agree with @berkaysynnada that this feature should have tests before we merge it. Since maintainer bandwidth is the most limited resource in this project, I suspect we might be waiting a while if we wait for a maintainer help write tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
