geoffreyclaude commented on code in PR #15563:
URL: https://github.com/apache/datafusion/pull/15563#discussion_r2030901421
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -966,6 +966,8 @@ pub struct SortExec {
preserve_partitioning: bool,
/// Fetch highest/lowest n results
fetch: Option<usize>,
+ /// Common sort prefix between the input and the sort expressions (only
used with fetch)
+ common_sort_prefix: LexOrdering,
Review Comment:
I'm not sure we can do that simply, as the `common_sort_prefix` is
normalized, and the `expr` is not. It would mean we'd need to re-normalize
`expr` everytime we need `common_sort_prefix`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
