geoffreyclaude commented on code in PR #15563:
URL: https://github.com/apache/datafusion/pull/15563#discussion_r2030868240
##########
datafusion/physical-expr/src/equivalence/properties/mod.rs:
##########
@@ -546,22 +546,23 @@ impl EquivalenceProperties {
self.ordering_satisfy_requirement(&sort_requirements)
}
- /// Checks whether the given sort requirements are satisfied by any of the
- /// existing orderings.
- pub fn ordering_satisfy_requirement(&self, reqs: &LexRequirement) -> bool {
- let mut eq_properties = self.clone();
- // First, standardize the given requirement:
- let normalized_reqs = eq_properties.normalize_sort_requirements(reqs);
-
+ /// Returns the number of consecutive requirements (starting from the left)
+ /// that are satisfied by the plan ordering.
+ fn compute_matching_prefix_length(&self, normalized_reqs: &LexRequirement)
-> usize {
Review Comment:
absolutely! `common_sort_prefix` everywhere it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
