friendlymatthew commented on PR #15361:
URL: https://github.com/apache/datafusion/pull/15361#issuecomment-2781505801
Some benchmark results when comparing main with this branch:
_(TLDR) This branch will make the existing `to_char` paths slower, at the
cost of adding the ability to format time-specifiers._
I compared two benchmark functions: `to_char_array_date_only_patterns_1000`
and `to_char_scalar_date_only_pattern_1000`.
These functions are concerned with formatting dates with date-only
specifiers.
From main:
```sh
to_char_array_date_only_patterns_1000
time: [136.39 µs 136.68 µs 137.03 µs]
to_char_scalar_date_only_pattern_1000
time: [92.084 µs 95.999 µs 100.12 µs]
```
And when compared to this branch:
```sh
to_char_array_date_only_patterns_1000
time: [173.46 µs 174.21 µs 175.10 µs]
change: [+25.159% +25.881% +26.651%] (p = 0.00 <
0.05)
Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high mild
to_char_scalar_date_only_pattern_1000
time: [105.04 µs 109.46 µs 113.80 µs]
change: [+6.6648% +11.410% +16.429%] (p = 0.00 <
0.05)
Performance has regressed.
```
### To reproduce:
You can run the two benchmark functions by:
```sh
cargo bench --package datafusion-functions
"to_char_array_date_only_patterns_1000|to_char_scalar_date_only_pattern_1000"
```
Since the benchmark function names clash between main and this branch, you
can consider [this
branch](https://github.com/apache/datafusion/compare/main...friendlymatthew:datafusion:friendlymatthew/date32-with-ts-format-main-reference)
representing main. (This branch only contains the refactor benchmark logic).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
