alamb commented on code in PR #15595:
URL: https://github.com/apache/datafusion/pull/15595#discussion_r2030130653
##########
.github/workflows/rust.yml:
##########
@@ -385,24 +385,24 @@ jobs:
linux-wasm-pack:
name: build with wasm-pack
- runs-on: ubuntu-latest
- container:
- image: amd64/rust
+ runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- - name: Setup Rust toolchain
- uses: ./.github/actions/setup-builder
- with:
- rust-version: stable
+ - name: Setup for wasm32
+ run: |
+ rustup target add wasm32-unknown-unknown
- name: Install dependencies
run: |
- apt-get update -qq
- apt-get install -y -qq clang
- - name: Install wasm-pack
- run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf
| sh
- - name: Build with wasm-pack
+ sudo apt-get update -qq
+ sudo apt-get install -y -qq clang
+ - name: Setup wasm-pack
+ run: |
+ cargo install wasm-pack
+ - name: Run tests with headless mode
working-directory: ./datafusion/wasmtest
- run: wasm-pack build --dev
+ run: |
+ wasm-pack test --headless --firefox
Review Comment:
😍
##########
.github/workflows/rust.yml:
##########
@@ -385,24 +385,24 @@ jobs:
linux-wasm-pack:
name: build with wasm-pack
Review Comment:
Can we update the name of this CI job too?
```suggestion
name: build and run with wasm-pack
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
