andygrove commented on code in PR #1610:
URL: https://github.com/apache/datafusion-comet/pull/1610#discussion_r2029937991


##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2459,6 +2459,10 @@ object QueryPlanSerde extends Logging with CometExprShim 
{
         }
 
         val groupingExprs = groupingExpressions.map(exprToProto(_, 
child.output))
+        if (groupingExprs.exists(_.isEmpty)) {
+          withInfo(op, "Not all grouping expressions are supported")
+          return None
+        }

Review Comment:
   This fixes https://github.com/apache/datafusion-comet/issues/1613



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to