dilovancelik commented on PR #1790: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1790#issuecomment-2773468790
> Thanks @dilovancelik! The changes look reasonable to me overall, left some comments @iffyio thanks a lot for the comments, I just applied your suggestions. For the other comments, I believe they make a lot of sense, and have implemented what you suggested. I have not resolved those conversations, since I don't know if you would like to do it your self after checking my new commits :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
