berkaysynnada commented on PR #15371: URL: https://github.com/apache/datafusion/pull/15371#issuecomment-2750398845
@jayzhan-synnada I've tried to break the `Session` dependency of `datasource` crate by converting `Session` references ConfigOptions, RuntimeEnvironment and TableOptions, but it's not straightforward to eliminate those in FileFormat and FileFormatFactory within a common pattern. Probably we need 1 or 2 different structs mapped from Session to be used in datasource, having the required data for FileFormat and FileFormatFactory API's. For now, I cannot estimate it's worth it. So, we can take this PR in, after updating 1) crate organization documentation 2) file documentation in session/lib.rs ( //! docs) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
