berkaysynnada commented on PR #15476: URL: https://github.com/apache/datafusion/pull/15476#issuecomment-2772106637
> This was not caught by the tests 2 weeks ago, because most plans can have a partition executed multiple times - but repartition can not. As the signature of execute() is not self consuming, what I believe is all execute()'s should be idempotent. If repartition breaks this, should we create a ticket for that? > I suspect there is no case where a CollectLeft join is used and a RepartitionExec is under the build side. Even if this case is not generated in tests at all, we should be prepared for that. > Alright, so what went wrong here is that for CollectLeft joins, the left ExecutionPlan gets executed _for every input partition_. The issue is now CollectLeft should always receive only 1 partition, by EnforceDistribution, right? Then, we can re-apply these changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
