alamb opened a new issue, #15317: URL: https://github.com/apache/datafusion/issues/15317
### Is your feature request related to a problem or challenge? @svranesevic implemented basic support for Min/Max Duration types in this PR: ❤ - https://github.com/apache/datafusion/pull/15310 However, this only implements the slower "Accumulator" interface. There is a faster [`GroupsAccumulator`](https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.GroupsAccumulator.html) that would be really nice to implement as well as it will be faster for larger numbers of groups. ### Describe the solution you'd like See [Notes on Implementing `GroupsAccumulator`](https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.GroupsAccumulator.html#notes-on-implementing-groupsaccumulator) for more detail ### Describe alternatives you've considered It basically involves 1. adding the correct Durations type in the list of supported types (the one for max is here): https://github.com/apache/datafusion/blob/42ec5109bb4c6249d8404e862c457ebd86ee0623/datafusion/functions-aggregate/src/min_max.rs#L243-L242 2. Instantiating an accumulator here: https://github.com/apache/datafusion/blob/42ec5109bb4c6249d8404e862c457ebd86ee0623/datafusion/functions-aggregate/src/min_max.rs#L270-L269 3. Writing some tests (perhaps add a few more rows to the test added in https://github.com/apache/datafusion/pull/15310) ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
