iffyio commented on code in PR #1791:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1791#discussion_r2029718008
##########
src/ast/spans.rs:
##########
@@ -739,19 +740,12 @@ impl Spanned for CreateIndex {
impl Spanned for CaseStatement {
fn span(&self) -> Span {
let CaseStatement {
- match_expr,
- when_blocks,
- else_block,
- has_end_case: _,
+ case_token: AttachedToken(start),
+ end_case_token: AttachedToken(end),
+ ..
Review Comment:
For this and `ConditionalStatement` Spanned impl could we explicitly list
the remaining fields so that the `let` match is exhaustive? So that we're
forced to revisit this part of the code if new fields are added/modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
