berkaysynnada commented on code in PR #15289:
URL: https://github.com/apache/datafusion/pull/15289#discussion_r2007300555
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -839,9 +839,10 @@ pub fn statistics_from_parquet_meta_calc(
total_byte_size += row_group_meta.total_byte_size() as usize;
if !has_statistics {
- row_group_meta.columns().iter().for_each(|column| {
Review Comment:
You are right, I wasn't oppose to your change. I was just thinking a further
refactor of unifying these two iterations:
```rust
row_group_meta.columns().iter().for_each(|column| {
has_statistics = column.statistics().is_some();
});
```
and
```rust
table_schema
.fields()
.iter()
.enumerate()
.for_each(|(idx, field)| {
...
```
but maybe not worth to try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
