GitHub user ozankabak added a comment to the discussion: More thorough
contribution guideline
Thank you @logan-keede for this. There is indeed a lot of refactoring going on
and I think we can do much better w.r.t. how we approach refactoring. A few
thoughts:
- We don't do a good job at managing downstream effects of refactors (for
forks, crate-level users and others): Refactors that seem innocuous/sensible
for DF core can turn out to be bad ideas in a larger context. It would be great
if we had a "protocol" for major refactor proposals; something that flows like:
1. Start with a proposal,
2. Create a feature branch containing the core ideas in the refactor for
downstream projects to experiment with,
3. Collect feedback from downstream projects to reveal any possible design
issues,
4. Publish a roadmap and upgrade guide
5. Proceed with the implementation on `main`.
- We should channel our contributors' time to highest-priority items; i.e.
direct their efforts into missing features, increasing test coverage and
regression fixes instead of refactors that only improve the status quo
slightly. I think we have a lot of refactors because it is "easy" to get
refactors merged -- low-impact refactors are not that hard to create a PR for,
but get merged without much scrutinization.
GitHub link:
https://github.com/apache/datafusion/discussions/15365#discussioncomment-12593505
----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
