andygrove commented on code in PR #1559: URL: https://github.com/apache/datafusion-comet/pull/1559#discussion_r2006509200
########## spark/src/test/scala/org/apache/spark/sql/CometTPCHQuerySuite.scala: ########## @@ -90,10 +90,8 @@ class CometTPCHQuerySuite extends QueryTest with TPCBase with ShimCometTPCHQuery conf.set(CometConf.COMET_EXEC_ENABLED.key, "true") conf.set(CometConf.COMET_NATIVE_SCAN_ENABLED.key, "true") conf.set(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key, "true") - conf.set(CometConf.COMET_SHUFFLE_MODE.key, "jvm") Review Comment: This is unrelated, but there is no reason for us to disable native shuffle now. I can revert this change and move to a separate PR if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org