parthchandra commented on code in PR #1609:
URL: https://github.com/apache/datafusion-comet/pull/1609#discussion_r2029143545
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -352,7 +352,7 @@ class CometSparkSessionExtensions
*/
// spotless:on
private def transform(plan: SparkPlan): SparkPlan = {
- def transform1(op: SparkPlan): Option[Operator] = {
+ def operatorToProto(op: SparkPlan): Option[Operator] = {
Review Comment:
`operator2Proto`, perhaps (to match the name in `QueryPlanSerde`)
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -366,6 +366,14 @@ class CometSparkSessionExtensions
}
}
+ /**
+ * Convert operator to proto and then apply a transformation to wrap the
proto in a new
+ * plan.
+ */
+ def wrapProto(op: SparkPlan, fun: Operator => SparkPlan): SparkPlan = {
Review Comment:
Can we call this something like `newPlanWithProto`? I'm fine with
`wrapProto` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
