geoffreyclaude commented on issue #15529: URL: https://github.com/apache/datafusion/issues/15529#issuecomment-2779122390
PR should be ready for review. I've included some pretty nice benchmark results from https://github.com/apache/datafusion/pull/15560: ``` > ./bench.sh compare main partitioned_topk Comparing main and partitioned_topk -------------------- Benchmark top10_sorted_tpch.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ partitioned_topk ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩ │ Q1 │ 24.73ms │ 24.86ms │ no change │ │ Q2 │ 5.42ms │ 5.27ms │ no change │ │ Q3 │ 77.20ms │ 76.83ms │ no change │ │ Q4 │ 28.43ms │ 5.41ms │ +5.26x faster │ │ Q5 │ 18.44ms │ 18.34ms │ no change │ │ Q6 │ 32.91ms │ 32.52ms │ no change │ │ Q7 │ 74.63ms │ 75.11ms │ no change │ │ Q8 │ 77.22ms │ 6.78ms │ +11.39x faster │ │ Q9 │ 90.10ms │ 10.04ms │ +8.97x faster │ │ Q10 │ 135.39ms │ 14.04ms │ +9.64x faster │ │ Q11 │ 72.33ms │ 71.06ms │ no change │ └──────────────┴──────────┴──────────────────┴────────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩ │ Total Time (main) │ 636.81ms │ │ Total Time (partitioned_topk) │ 340.26ms │ │ Average Time (main) │ 57.89ms │ │ Average Time (partitioned_topk) │ 30.93ms │ │ Queries Faster │ 4 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 7 │ └─────────────────────────────────┴──────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
