Kontinuation commented on code in PR #1568:
URL: https://github.com/apache/datafusion-comet/pull/1568#discussion_r2026121620
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -232,20 +222,23 @@ object CometShuffleExchangeExec extends
ShimCometShuffleExchangeExec {
(0, _)
), // adding fake partitionId that is always 0 because ShuffleDependency
requires it
serializer = serializer,
- shuffleWriterProcessor =
- new CometShuffleWriteProcessor(outputPartitioning, outputAttributes,
metrics, numParts),
+ shuffleWriterProcessor =
ShuffleExchangeExec.createShuffleWriteProcessor(metrics),
Review Comment:
Yes. `ShuffleExchangeExec.createShuffleWriteProcessor` will call `getWriter`
of the shuffle manager internally (will be `CometShuffleManager` when comet
shuffle is enabled). `CometShuffleManager.getWriter` will initialize a
`CometNativeShuffleWriter` when shuffle type is `CometNativeShuffle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
