Kontinuation commented on code in PR #1568:
URL: https://github.com/apache/datafusion-comet/pull/1568#discussion_r2016905005
##########
spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala:
##########
@@ -201,6 +204,17 @@ class CometNativeShuffleSuite extends CometTestBase with
AdaptiveSparkPlanHelper
}
}
+ test("fix: Comet native shuffle deletes shuffle files after query") {
+ withParquetTable((0 until 5).map(i => (i, i + 1)), "tbl") {
+ sql("SELECT count(_2), sum(_2) FROM tbl GROUP BY _1").collect()
+ val diskBlockManager = SparkEnv.get.blockManager.diskBlockManager
+ eventually(timeout(30.seconds), interval(1.seconds)) {
Review Comment:
Asserted that the files list is non-empty. I have to hold the reference to
the DataFrame while asserting to prevent from GC kicking in just before the
assertion.
##########
spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala:
##########
@@ -201,6 +204,17 @@ class CometNativeShuffleSuite extends CometTestBase with
AdaptiveSparkPlanHelper
}
}
+ test("fix: Comet native shuffle deletes shuffle files after query") {
+ withParquetTable((0 until 5).map(i => (i, i + 1)), "tbl") {
+ sql("SELECT count(_2), sum(_2) FROM tbl GROUP BY _1").collect()
+ val diskBlockManager = SparkEnv.get.blockManager.diskBlockManager
+ eventually(timeout(30.seconds), interval(1.seconds)) {
Review Comment:
Asserted that the files list is non-empty. I have to hold a reference to the
DataFrame while asserting to prevent from GC kicking in just before the
assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
