berkaysynnada commented on PR #15532: URL: https://github.com/apache/datafusion/pull/15532#issuecomment-2772920116
> This seems like it changes the semantics of the query and does not guarantee the correct results. I am thinking specifically about order-of-operations when applying this to decimal types for example where there could be rounding differences. I believe this optimization reduces the number of arithmetic operations, which should lead to smaller cumulative numerical errors compared to the existing brute force approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
