parthchandra commented on code in PR #1587:
URL: https://github.com/apache/datafusion-comet/pull/1587#discussion_r2023778763
##########
native/core/src/parquet/mod.rs:
##########
@@ -650,21 +651,29 @@ pub unsafe extern "system" fn
Java_org_apache_comet_parquet_Native_initRecordBat
required_schema: jbyteArray,
data_schema: jbyteArray,
session_timezone: jstring,
+ batch_size: jint,
+ worker_threads: jint,
+ blocking_threads: jint,
) -> jlong {
try_unwrap_or_throw(&e, |mut env| unsafe {
- let task_ctx = TaskContext::default();
+ let session_config = SessionConfig::new().with_batch_size(batch_size
as usize);
+ let planer =
Review Comment:
Do we need to create a new planner here? We really only need a
session_config (even though it is really not valid for the entire session).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
