mbutrovich opened a new pull request, #15537: URL: https://github.com/apache/datafusion/pull/15537
Note this PR is a draft because it 1) relies on an unreleased arrow-rs version so there are cargo dependencies that I will remove after DF bumps its arrow-rs dependency, and 2) relies on an [unapproved parquet-testing PR](https://github.com/apache/parquet-testing/pull/73). I'm opening this as a draft to signal to other dependencies and try to get the timing right for upcoming releases. ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - N/A. ## Rationale for this change We are adding Spark-compatible int96 support to [DataFusion Comet](https://github.com/apache/datafusion-comet) when using arrow-rs's Parquet reader. To achieve this, we first added support for [arrow-rs to read int96 at different resolutions than nanosecond](https://github.com/apache/arrow-rs/pull/7285). It would previously generate nulls for non-null values. Next, we will add support to DataFusion to generate the necessary schema for arrow-rs to read int96 at the resolution that Spark expects. Finally, we will connect everything together in DataFusion Comet for accelerated Parquet reading with int96 values. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - new option in `ParquetOptions` to coerce int96 resolution, with serialization support (I think I did this correctly) ## Are these changes tested? Added a new test that relies on https://github.com/apache/parquet-testing/pull/73 being approved and merged. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> There is a new field in `ParquetOptions` and corresponding mutator. There is an API-change to a `pub(crate)` test function to accept a provided table schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
