jayzhan211 commented on issue #15511: URL: https://github.com/apache/datafusion/issues/15511#issuecomment-2769754304
> > I don't think we need to actually "benchmark" the code for each merge. > > The issue [#5504](https://github.com/apache/datafusion/issues/5504) would require all benchmarks to run after each merge. I think we could just add benchmarks directly for now. What do you think? > > I am willing to work on* this. I don't think we need to run the benchmark on CI, at least it should be optional and disable by default. > We could do that too however not all benchmarks are sql queries. I agree that maintaining it is challenging. Adding it to the extended test suite and running it on every merge isn’t a viable solution, as it’s costly and often unnecessary. I don’t think keeping the benchmark functional is essential—it’s more like a script that we can modify as needed, depending on what we want to measure each time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
