chenkovsky commented on PR #15457: URL: https://github.com/apache/datafusion/pull/15457#issuecomment-2763209390
> > count（*） actually doesnt depend on any column on input logically > > count(*) need to know the row number of the column, and it doesn't make sense to count all on "empty" column, so I guess keeping the column in logical plan makes more sense but, for ```sql with test AS (SELECT i as needle FROM generate_series(1, 10) t(i)) select count(*), i from test WHERE 1 = 1 group by i; ``` there's no row number in both physical and logical plan. do you think we should also add row number for this sql? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
