Dandandan commented on code in PR #15479: URL: https://github.com/apache/datafusion/pull/15479#discussion_r2019008151
########## datafusion/physical-optimizer/src/coalesce_batches.rs: ########## @@ -92,3 +92,73 @@ impl PhysicalOptimizerRule for CoalesceBatches { true } } + +/// Remove CoalesceBatchesExec that are in front of a AggregateExec +#[derive(Default, Debug)] +pub struct UnCoalesceBatches {} Review Comment: I am wondering if we instead can avoid adding them in the `CoalesceBatches` optimizer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org